Skip to content

Fix CLI version reporting - #42

Merged
joerj123 merged 1 commit into
Shopify:mainfrom
richpoirier:fix-dynamic-cli-version
Sep 2, 2026
Merged

Fix CLI version reporting#42
joerj123 merged 1 commit into
Shopify:mainfrom
richpoirier:fix-dynamic-cli-version

Conversation

@richpoirier

@richpoirier richpoirier commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
rich@MacBook-Pro-3 shop-cli % pnpm shop --version

> @shopify/shop-cli@0.1.2 shop /Users/rich/src/github.com/Shopify/shop-cli
> node dist/bin.js --version

0.1.2

shop --version and the outbound User-Agent still report 0.1.0 after package releases because CLI_VERSION is hard-coded.

Read the version from the package manifest so package version bumps update both values automatically. Throw if that version is missing or empty. Add a regression test covering both values, and a patch changeset so the next publish includes the fix.

@richpoirier
richpoirier marked this pull request as ready for review September 1, 2026 20:44
@richpoirier
richpoirier force-pushed the fix-dynamic-cli-version branch from 3e8ed4f to 278d796 Compare September 1, 2026 20:45
@richpoirier
richpoirier force-pushed the fix-dynamic-cli-version branch from 278d796 to ed71a90 Compare September 1, 2026 21:11
@joerj123
joerj123 merged commit 5027485 into Shopify:main Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants